mirrors/haproxy
1
0
Fork 0
mirror of https://git.haproxy.org/git/haproxy.git/ synced 2025-08-11 17:46:57 +02:00
Code Issues Projects Releases Wiki Activity

BUG/MINOR: activity/memprofile: reinitialize the free calls on DSO summary

Browse Source 
In commit 401fb0e87a ("MINOR: activity/memprofile: show per-DSO stats")
we added a summary per DSO. However the free calls/tot were not initialized
when creating a new entry because initially they were applied to any entry,
but since we don't update free calls for non-free capable callers, we still
need to reinitialize these entries when reassigning one. Because of this
bug, a "show profiling memory" output can randomly show highly negative
values on the DSO lines if it turns out that the DSO entry was created on
an alloc instead of a realloc/free.

Since the commit above was backported to 2.9, this one must go there as
well.
This commit is contained in:
Willy Tarreau 2024-11-21 15:26:23 +01:00
parent 24ce001771
commit c42a2b8c94
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/activity.c
View File

@ -900,6 +900,9 @@ static int cli_io_handler_show_profiling(struct appctx *appctx)
(entry->method != MEMPROF_METH_CALLOC)) {
tmp_memstats[j].free_calls = entry->free_calls;
tmp_memstats[j].free_tot = entry->free_tot;
} else {
tmp_memstats[j].free_calls = 0;
tmp_memstats[j].free_tot = 0;
}
} else {
tmp_memstats[j].alloc_calls += entry->alloc_calls;