mirrors/haproxy
1
0
Fork 0
mirror of https://git.haproxy.org/git/haproxy.git/ synced 2025-09-20 21:31:28 +02:00
Code Issues Projects Releases Wiki Activity

BUG/MINOR: acl: Add OOM check for calloc() in smp_fetch_acl_parse()

Browse Source 
This patch adds a missing out-of-memory (OOM) check after
the call to `calloc()` in `smp_fetch_acl_parse()`. If
memory allocation fails, an error message is set and
the function returns 0, improving robustness in
low-memory situations.

Co-authored-by: Christian Norbert Menges <christian.norbert.menges@sap.com>
This commit is contained in:
Alexander Stephan 2025-09-01 09:47:30 +00:00 committed by Willy Tarreau
parent 22ac1f5ee9
commit c3e69cf065
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/acl.c
View File

@ -1351,6 +1351,10 @@ int smp_fetch_acl_parse(struct arg *args, char **err_msg)
for (i = 0; args[i].type != ARGT_STOP; i++) for (i = 0; args[i].type != ARGT_STOP; i++)
; ;
acl_sample = calloc(1, sizeof(struct acl_sample) + sizeof(struct acl_term) * i); acl_sample = calloc(1, sizeof(struct acl_sample) + sizeof(struct acl_term) * i);
if (unlikely(!acl_sample)) {
memprintf(err_msg, "out of memory when parsing ACL expression");
return 0;
}
LIST_INIT(&acl_sample->suite.terms); LIST_INIT(&acl_sample->suite.terms);
LIST_INIT(&acl_sample->cond.suites); LIST_INIT(&acl_sample->cond.suites);
LIST_APPEND(&acl_sample->cond.suites, &acl_sample->suite.list); LIST_APPEND(&acl_sample->cond.suites, &acl_sample->suite.list);