From c3b1183f57250f8e969b22dc4718c63e601d685f Mon Sep 17 00:00:00 2001 From: Willy Tarreau Date: Tue, 7 May 2019 14:44:41 +0200 Subject: [PATCH] MINOR: mux-h2: remove useless test on stream ID vs last in wake function h2_wake_some_streams() first looks up streams whose IDs are greater than or equal to last+1, then checks if the id is lower than or equal to last, which by definition will never match. Let's remove this confusing leftover from ancient code. --- src/mux_h2.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/mux_h2.c b/src/mux_h2.c index c4588eec5..40ff11a7e 100644 --- a/src/mux_h2.c +++ b/src/mux_h2.c @@ -1464,8 +1464,6 @@ static void h2_wake_some_streams(struct h2c *h2c, int last, uint32_t flags) node = eb32_lookup_ge(&h2c->streams_by_id, last + 1); while (node) { h2s = container_of(node, struct h2s, by_id); - if (h2s->id <= last) - break; node = eb32_next(node); h2s_wake_one_stream(h2s, flags); }