mirrors/haproxy
1
0
Fork 0
mirror of https://git.haproxy.org/git/haproxy.git/ synced 2025-10-26 22:20:59 +01:00
Code Issues Projects Releases Wiki Activity

BUG/MINOR: sink: retry attempt for sft server may never occur

Browse Source 
Since 9561b9fb6 ("BUG/MINOR: sink: add tempo between 2 connection
attempts for sft servers"), there is a possibility that the tempo we use
to schedule the task expiry may point to TICK_ETERNITY as we add ticks to
tempo with a simple addition that doesn't take care of potential wrapping.

When this happens (although relatively rare, since now_ms only wraps every
49.7 days, but a forced wrap occurs 20 seconds after haproxy is started
so it is more likely to happen there), the process_sink_forward() task
expiry being set to TICK_ETERNITY, it may never be called again, this
is especially true if the ring section only contains a single server.

To fix the issue, we must use tick_add() helper function to set the tempo
value and this way we ensure that the value will never be TICK_ETERNITY.

It must be backported everywhere 9561b9fb6 was backported (up to 2.6
it seems).
This commit is contained in:
Aurelien DARRAGON 2025-10-02 21:40:57 +02:00
parent b01a00acb1
commit c26ac3f5e4
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/sink.c
View File

@ -701,7 +701,7 @@ static struct task *process_sink_forward(struct task * task, void *context, unsi
* establishment attempt per second.
*/
if (!sft->appctx) {
uint tempo = sft->last_conn + MS_TO_TICKS(1000);
int tempo = tick_add(sft->last_conn, MS_TO_TICKS(1000));
if (sft->last_conn == TICK_ETERNITY || tick_is_expired(tempo, now_ms))
sft->appctx = sink_forward_session_create(sink, sft);