mirrors/haproxy
1
0
Fork 0
mirror of https://git.haproxy.org/git/haproxy.git/ synced 2025-11-28 22:31:06 +01:00
Code Issues Projects Releases Wiki Activity

BUG/MAJOR: http: don't manipulate the server connection if it's killed

Browse Source 
Jesse Hathaway reported a crash that Cyril Bont diagnosed as being
caused by the manipulation of srv_conn after setting it to NULL. This
happens in http-server-close mode when the server returns either a 401
or a 407, because the connection was previously closed then it's being
assigned the CO_FL_PRIVATE flag.

This bug only affects 1.6-dev as it was introduced by connection reuse code
with commit 387ebf8 ("MINOR: connection: add a new flag CO_FL_PRIVATE").
This commit is contained in:
Willy Tarreau 2015-09-02 10:40:43 +02:00
parent 61d301fbfb
commit bd99d5818d
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/proto_http.c
View File

@ -5246,7 +5246,8 @@ void http_end_txn_clean_session(struct stream *s)
* it's better to do it (at least it helps with debugging). * it's better to do it (at least it helps with debugging).
*/ */
s->txn->flags |= TX_PREFER_LAST; s->txn->flags |= TX_PREFER_LAST;
srv_conn->flags |= CO_FL_PRIVATE; if (srv_conn)
srv_conn->flags |= CO_FL_PRIVATE;
} }
if (fe->options2 & PR_O2_INDEPSTR) if (fe->options2 & PR_O2_INDEPSTR)