mirrors/haproxy
1
0
Fork 0
mirror of https://git.haproxy.org/git/haproxy.git/ synced 2026-03-15 20:12:08 +01:00
Code Issues Projects Releases Wiki Activity

MINOR: mworker: add a BUG_ON() on mproxy_li in _send_status

Browse Source 
mproxy_li is supposed to be used in _send_status to stop the sockpair FD
between the master and the new worker, being a listener.

This can only work if the listener has been stored in the fdtab owner,
and there's no reason it shouldn't be here.
This commit is contained in:
William Lallemand 2026-03-05 15:54:13 +01:00
parent 520faedda0
commit bd3983b595
1 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/cli.c
View File

@ -2628,7 +2628,14 @@ static int _send_status(char **args, char *payload, struct appctx *appctx, void
/* update status of the new worker */
if (proc->pid == pid) {
proc->options &= ~PROC_O_INIT;
/* the sockpair between the master and the worker is
* used temporarly as a listener to receive
* _send_status. Once it is received we don't want to
* use this FD as a listener anymore, but only as a
* server, to allow only connections from the master to
* the worker for the master CLI */
mproxy_li = fdtab[proc->ipc_fd[0]].owner;
BUG_ON(mproxy_li == NULL);
stop_listener(mproxy_li, 0, 0, 0);
}
/* send TERM to workers, which have exceeded max_reloads counter */