mirrors/haproxy
1
0
Fork 0
mirror of https://git.haproxy.org/git/haproxy.git/ synced 2025-09-23 06:41:32 +02:00
Code Issues Projects Releases Wiki Activity

BUG/MINOR: quic: TX frames memleak

Browse Source 
Missing call to pool_free() for quic_frame objects

Must be backported to 2.6.
This commit is contained in:
Frdric Lcaille 2022-08-31 15:02:53 +02:00 committed by Willy Tarreau
parent 3a9b944955
commit bccbad2654
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/xprt_quic.c
View File

@ -1764,6 +1764,7 @@ static inline void qc_requeue_nacked_pkt_tx_frms(struct quic_conn *qc,
if (strm_frm->offset.key + strm_frm->len <= stream_desc->ack_offset) { if (strm_frm->offset.key + strm_frm->len <= stream_desc->ack_offset) {
TRACE_DEVEL("ignored frame in already acked range", TRACE_DEVEL("ignored frame in already acked range",
QUIC_EV_CONN_PRSAFRM, qc, frm); QUIC_EV_CONN_PRSAFRM, qc, frm);
pool_free(pool_head_quic_frame, frm);
continue; continue;
} }
else if (strm_frm->offset.key < stream_desc->ack_offset) { else if (strm_frm->offset.key < stream_desc->ack_offset) {
@ -3424,6 +3425,7 @@ static int quic_build_post_handshake_frames(struct quic_conn *qc)
LIST_INIT(&frm->reflist); LIST_INIT(&frm->reflist);
cid = new_quic_cid(&qc->cids, qc, i); cid = new_quic_cid(&qc->cids, qc, i);
if (!cid) { if (!cid) {
pool_free(pool_head_quic_frame, frm);
TRACE_ERROR("CID allocation error", QUIC_EV_CONN_IO_CB, qc); TRACE_ERROR("CID allocation error", QUIC_EV_CONN_IO_CB, qc);
goto err; goto err;
} }