From bb5b62ee5c0ce5077559c6f42ad1fb4451bf95de Mon Sep 17 00:00:00 2001 From: Christopher Faulet Date: Thu, 21 Apr 2022 10:28:30 +0200 Subject: [PATCH] BUG/MINOR: backend: Don't allow to change backend applet This part was inherited from haproxy-1.5. But since a while (at least 1.8), the backend applet, once created, is no longer changed. Thus there is no reason to still check if the target has changed. And in fact, if it was still possible, there would be a memory leak because the old applet would be lost and never released. There is no reason to backport this fix because the leak only exists on a dead code path. --- src/backend.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/backend.c b/src/backend.c index 8255ffbe7..12f9a651b 100644 --- a/src/backend.c +++ b/src/backend.c @@ -2129,7 +2129,7 @@ void back_handle_st_req(struct stream *s) /* the applet directly goes to the EST state */ struct appctx *appctx = cs_appctx(s->csb); - if (!appctx || appctx->applet != __objt_applet(s->target)) + if (!appctx) appctx = cs_applet_create(cs, objt_applet(s->target)); if (!appctx) {