From b829f4c7261779199153f19a0257332f365217b5 Mon Sep 17 00:00:00 2001 From: Christopher Faulet Date: Fri, 29 Mar 2019 16:13:55 +0100 Subject: [PATCH] MINOR: stats/htx: Don't add "Connection: close" header anymore in stats responses On the client side, as far as possible, we will try to keep connection alive. So, in most of cases, this header will be removed. So it is better to not add it at all. If finally the connection must be closed, the header will be added by the mux h1. No need to backport this patch. --- src/stats.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/stats.c b/src/stats.c index 965fe4299..346c62912 100644 --- a/src/stats.c +++ b/src/stats.c @@ -3114,8 +3114,7 @@ static int stats_send_htx_headers(struct stream_interface *si, struct htx *htx) goto full; sl->info.res.status = 200; - if (!htx_add_header(htx, ist("Cache-Control"), ist("no-cache")) || - !htx_add_header(htx, ist("Connection"), ist("close"))) + if (!htx_add_header(htx, ist("Cache-Control"), ist("no-cache"))) goto full; if (appctx->ctx.stats.flags & STAT_FMT_HTML) { if (!htx_add_header(htx, ist("Content-Type"), ist("text/html"))) @@ -3191,7 +3190,6 @@ static int stats_send_htx_redirect(struct stream_interface *si, struct htx *htx) sl->info.res.status = 303; if (!htx_add_header(htx, ist("Cache-Control"), ist("no-cache")) || - !htx_add_header(htx, ist("Connection"), ist("close")) || !htx_add_header(htx, ist("Content-Type"), ist("text/plain")) || !htx_add_header(htx, ist("Content-Length"), ist("0")) || !htx_add_header(htx, ist("Location"), ist2(trash.area, trash.data)))