mirrors/haproxy
1
0
Fork 0
mirror of https://git.haproxy.org/git/haproxy.git/ synced 2026-04-20 05:02:11 +02:00
Code Issues Projects Releases Wiki Activity

BUG/MINOR: xprt_qstrm: do not parse record length on read again

Browse Source 
conn_recv_qstrm() may be called several times per connection if the read
data is too short and a truncated record is received.

Previously, record length was parsed every time the function is invoked.
However, this must only be performed if record length varint is
incomplete. Once read and parsed, data are removed from the buffer via
b_quic_dec_int(). Thus, next conn_recv_qstrm() run will reread an
invalid record length this time.

This patch fixes this by only parsing record length if <rxrlen> member
is null. Prior to it, parsing of QMux transport parameters would fail in
case of a first truncated read, which would prevent the connection
initialization.

No need to backport.
This commit is contained in:
Amaury Denoyelle 2026-04-13 08:47:01 +02:00
parent b5624a6365
commit b8145fa5d4
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/xprt_qstrm.c
View File

@ -81,7 +81,7 @@ int conn_recv_qstrm(struct connection *conn, struct xprt_qstrm_ctx *ctx, int fla
goto not_ready;
/* Read record length. */
if (!b_quic_dec_int(&ctx->rxrlen, buf, NULL))
if (!ctx->rxrlen && !b_quic_dec_int(&ctx->rxrlen, buf, NULL))
goto not_ready;
/* Reject too small or too big records. */