mirrors/haproxy
1
0
Fork 0
mirror of https://git.haproxy.org/git/haproxy.git/ synced 2025-09-21 22:01:31 +02:00
Code Issues Projects Releases Wiki Activity

BUG/MINOR: quic: Useless I/O handler task wakeups (draining, killing state)

Browse Source 
From the idle_timer_task(), the I/O handler must be woken up to send ack. But
there is no reason to do that in draining state or killing state. In draining
state this is even forbidden.

Must be backported to 2.7.
This commit is contained in:
Frédéric Lécaille 2023-04-24 11:32:22 +02:00
parent d21c628ffd
commit b73762ad78
1 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/quic_conn.c
View File

@ -5882,8 +5882,14 @@ struct task *qc_idle_timer_task(struct task *t, void *ctx, unsigned int state)
qc->ack_expire = TICK_ETERNITY; qc->ack_expire = TICK_ETERNITY;
/* Note that ->idle_expire is always set. */ /* Note that ->idle_expire is always set. */
t->expire = qc->idle_expire; t->expire = qc->idle_expire;
qc->flags |= QUIC_FL_CONN_ACK_TIMER_FIRED; /* Do not wakeup the I/O handler in DRAINING state or if the
tasklet_wakeup(qc->wait_event.tasklet); * connection must be killed as soon as possible.
*/
if (!(qc->flags & (QUIC_FL_CONN_DRAINING|QUIC_FL_CONN_TO_KILL))) {
qc->flags |= QUIC_FL_CONN_ACK_TIMER_FIRED;
tasklet_wakeup(qc->wait_event.tasklet);
}
goto requeue; goto requeue;
} }