mirrors/haproxy
1
0
Fork 0
mirror of https://git.haproxy.org/git/haproxy.git/ synced 2025-08-09 16:47:18 +02:00
Code Issues Projects Releases Wiki Activity

BUG/MINOR: http: Missing calloc return value check while parsing redirect rule

Browse Source 
A memory allocation failure happening in http_parse_redirect_rule when
trying to allocate a redirect_rule structure would have resulted in a
crash. This function is only called during configuration parsing.

It was raised in GitHub issue #1233.
It could be backported to all stable branches.
This commit is contained in:
Remi Tricot-Le Breton 2021-05-19 11:32:04 +02:00 committed by Christopher Faulet
parent 1f4fa906c7
commit b6864a5b6f
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/http_rules.c
View File

@ -408,6 +408,10 @@ struct redirect_rule *http_parse_redirect_rule(const char *file, int linenum, st
} }
rule = calloc(1, sizeof(*rule)); rule = calloc(1, sizeof(*rule));
if (!rule) {
memprintf(errmsg, "parsing [%s:%d]: out of memory.", file, linenum);
return NULL;
}
rule->cond = cond; rule->cond = cond;
LIST_INIT(&rule->rdr_fmt); LIST_INIT(&rule->rdr_fmt);