mirrors/haproxy
1
0
Fork 0
mirror of https://git.haproxy.org/git/haproxy.git/ synced 2025-09-24 15:21:29 +02:00
Code Issues Projects Releases Wiki Activity

MINOR: h3: do not wait a complete frame for demuxing

Browse Source 
Previously, H3 demuxer refused to proceed the payload if the frame was
not entirely received and the QCS buffer is not full. This code was
duplicated from the H2 demuxer.

In H2, this is a justified optimization as only one frame at a time can
be demuxed. However, this is not the case in H3 with interleaved frames
in the lower layer QUIC STREAM frames.

This condition is now removed. H3 demuxer will proceed payload as soon
as possible. An exception is kept for HEADERS frame as the code is not
able to deal with partial HEADERS.

With this change, H3 demuxer should consume less memory. To ensure that
we never received a HEADER bigger than the RX buffer, we should use the
H3 SETTINGS_MAX_FIELD_SECTION_SIZE.
This commit is contained in:
Amaury Denoyelle 2022-05-12 16:56:16 +02:00
parent 03dcf560ae
commit b5454d42df
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/h3.c
View File

@ -288,8 +288,11 @@ static int h3_decode_qcs(struct qcs *qcs, int fin, void *ctx)
flen = h3s->demux_frame_len; flen = h3s->demux_frame_len;
ftype = h3s->demux_frame_type; ftype = h3s->demux_frame_type;
if (flen > b_data(&b) && !ncb_is_full(rxbuf)) /* Do not demux HEADERS if frame incomplete. */
if (ftype == H3_FT_HEADERS && flen > b_data(&b)) {
BUG_ON(ncb_is_full(rxbuf)); /* TODO should define SETTINGS for max header size */
break; break;
}
last_stream_frame = (fin && flen == ncb_total_data(rxbuf)); last_stream_frame = (fin && flen == ncb_total_data(rxbuf));
switch (ftype) { switch (ftype) {