mirrors/haproxy
1
0
Fork 0
mirror of https://git.haproxy.org/git/haproxy.git/ synced 2025-09-23 14:51:27 +02:00
Code Issues Projects Releases Wiki Activity

BUG/MINOR: mux-h2: Fix missing braces because of traces in h2_detach()

Browse Source 
Braces was missing aroung a "if" statement in the function h2_detach(), leaving
an unconditional return.

No backport needed.
This commit is contained in:
Christopher Faulet 2019-09-26 16:15:10 +02:00
parent 13ed9faecd
commit b2d930ebe6
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/mux_h2.c
View File

@ -3786,10 +3786,11 @@ static void h2_detach(struct conn_stream *cs)
} }
} }
if (eb_is_empty(&h2c->streams_by_id)) { if (eb_is_empty(&h2c->streams_by_id)) {
if (session_check_idle_conn(h2c->conn->owner, h2c->conn) != 0) if (session_check_idle_conn(h2c->conn->owner, h2c->conn) != 0) {
/* At this point either the connection is destroyed, or it's been added to the server idle list, just stop */ /* At this point either the connection is destroyed, or it's been added to the server idle list, just stop */
TRACE_DEVEL("leaving without reusable idle connection", H2_EV_STRM_END); TRACE_DEVEL("leaving without reusable idle connection", H2_EV_STRM_END);
return; return;
}
} }
/* Never ever allow to reuse a connection from a non-reuse backend */ /* Never ever allow to reuse a connection from a non-reuse backend */
if ((h2c->proxy->options & PR_O_REUSE_MASK) == PR_O_REUSE_NEVR) if ((h2c->proxy->options & PR_O_REUSE_MASK) == PR_O_REUSE_NEVR)