mirrors/haproxy
1
0
Fork 0
mirror of https://git.haproxy.org/git/haproxy.git/ synced 2025-08-08 08:07:10 +02:00
Code Issues Projects Releases Wiki Activity

BUG/MINOR: flt-trace: Support only one name option

Browse Source 
When a trace filter is defined, only one 'name' option is expected. But it
was not tested. Thus it was possible to set several names leading to a
memory leak.

It is now tested, and it is not allowed to redefine the trace filter name.

It was reported by Coverity in #2841: CID 1587768.

This patch could be backported to all stable versions.
This commit is contained in:
Christopher Faulet 2025-02-06 17:01:08 +01:00
parent a7f513af91
commit b20e2c96cf
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/flt_trace.c
View File

@ -631,6 +631,11 @@ parse_trace_flt(char **args, int *cur_arg, struct proxy *px,
args[*cur_arg], args[pos]); args[*cur_arg], args[pos]);
goto error; goto error;
} }
if (conf->name) {
memprintf(err, "'%s' : '%s' option already defined",
args[*cur_arg], args[pos]);
goto error;
}
conf->name = strdup(args[pos + 1]); conf->name = strdup(args[pos + 1]);
if (!conf->name) { if (!conf->name) {
memprintf(err, "%s: out of memory", args[*cur_arg]); memprintf(err, "%s: out of memory", args[*cur_arg]);