From aee4fdbd175b66b2263e7676ab3dc4f3f780ccab Mon Sep 17 00:00:00 2001 From: Amaury Denoyelle Date: Wed, 20 Oct 2021 15:22:20 +0200 Subject: [PATCH] BUG/MINOR: backend: fix improper insert in avail tree for always reuse In connect_server(), if http-reuse always is set, the backend connection is inserted into the available tree as soon as created. However, the hash connection field is only set later at the end of the function. This seems to have no impact as the hash connection field is always position before a lookup. However, this is not a proper usage of ebmb API. Fix this by setting the hash connection field before the insertion into the avail tree. This must be backported up to 2.4. --- src/backend.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/backend.c b/src/backend.c index 4c7aba1f8..6d77864db 100644 --- a/src/backend.c +++ b/src/backend.c @@ -1523,6 +1523,8 @@ skip_reuse: conn_free(srv_conn); return SF_ERR_RESOURCE; } + + srv_conn->hash_node->hash = hash; } } @@ -1746,8 +1748,6 @@ skip_reuse: } } - srv_conn->hash_node->hash = hash; - return SF_ERR_NONE; /* connection is OK */ }