From ae3056157c17b181c754556836a5d8336fb9823f Mon Sep 17 00:00:00 2001 From: Christopher Faulet Date: Mon, 1 Mar 2021 11:33:59 +0100 Subject: [PATCH] BUG/MINOR: connection: Use the client's dst family for adressless servers When the selected server has no address, the destination address of the client is used. However, for now, only the address is set, not the family. Thus depending on how the server is configured and the client's destination address, the server address family may be wrong. For instance, with such server : server srv 0.0.0.0:0 The server address family is AF_INET. The server connection will fail if a client is asking for an IPv6 destination. To fix the bug, we take care to set the rigth family, the family of the client destination address. This patch should fix the issue #202. It must be backported to all stable versions. --- src/backend.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/backend.c b/src/backend.c index 0602016dc..3cf8b27b8 100644 --- a/src/backend.c +++ b/src/backend.c @@ -861,9 +861,11 @@ static int alloc_dst_address(struct sockaddr_storage **ss, if (!conn_get_dst(cli_conn)) { /* do nothing if we can't retrieve the address */ } else if (cli_conn->dst->ss_family == AF_INET) { + ((struct sockaddr_in *)*ss)->sin_family = AF_INET; ((struct sockaddr_in *)*ss)->sin_addr = ((struct sockaddr_in *)cli_conn->dst)->sin_addr; } else if (cli_conn->dst->ss_family == AF_INET6) { + ((struct sockaddr_in6 *)*ss)->sin6_family = AF_INET6; ((struct sockaddr_in6 *)*ss)->sin6_addr = ((struct sockaddr_in6 *)cli_conn->dst)->sin6_addr; }