mirrors/haproxy
1
0
Fork 0
mirror of https://git.haproxy.org/git/haproxy.git/ synced 2025-08-07 07:37:02 +02:00
Code Issues Projects Releases Wiki Activity

BUG/MINOR: namespace: handle a possible strdup() failure

Browse Source 
This defect was found by the coccinelle script "unchecked-strdup.cocci".
It can be backported to all supported branches.
This commit is contained in:
Ilia Shipitsin 2024-12-03 17:10:21 +01:00 committed by Willy Tarreau
parent 1f63a53955
commit abee546850
1 changed files with 11 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/namespace.c
View File

@ -89,13 +89,23 @@ struct netns_entry* netns_store_insert(const char *ns_name)
entry = calloc(1, sizeof(*entry)); entry = calloc(1, sizeof(*entry));
if (!entry) if (!entry)
goto out; goto err_close_fd;
entry->fd = fd; entry->fd = fd;
entry->node.key = strdup(ns_name); entry->node.key = strdup(ns_name);
if (!entry->node.key)
goto err_free_entry;
entry->name_len = strlen(ns_name); entry->name_len = strlen(ns_name);
ebis_insert(&namespace_tree_root, &entry->node); ebis_insert(&namespace_tree_root, &entry->node);
out: out:
return entry; return entry;
/* free all allocated stuff and return entry */
err_free_entry:
ha_free(&entry);
err_close_fd:
close(fd);
return entry;
} }
const struct netns_entry* netns_store_lookup(const char *ns_name, size_t ns_name_len) const struct netns_entry* netns_store_lookup(const char *ns_name, size_t ns_name_len)