mirrors/haproxy
1
0
Fork 0
mirror of https://git.haproxy.org/git/haproxy.git/ synced 2025-09-23 06:41:32 +02:00
Code Issues Projects Releases Wiki Activity

BUG/MEDIUM: threads: fix the no-thread case after the change to the sync point

Browse Source 
In commit 0c026f4 ("MINOR: threads: add more consistency between certain
variables in no-thread case"), we ensured that we don't have all_threads_mask
zeroed anymore. But one test was missed for the write() to the sync pipe.
This results in a situation where when running single-threaded, once a
server status changes, a wake-up message is written to the pipe and never
consumed, showing a 100% CPU usage.

No backport is needed.
This commit is contained in:
Willy Tarreau 2018-08-07 10:07:15 +02:00
parent ad4e1a4735
commit ab657ce251
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/hathreads.c
View File

@ -70,7 +70,7 @@ void thread_sync_enable(void)
*/ */
void thread_want_sync() void thread_want_sync()
{ {
if (all_threads_mask) { if (all_threads_mask & (all_threads_mask - 1)) {
if (threads_want_sync & tid_bit) if (threads_want_sync & tid_bit)
return; return;
if (HA_ATOMIC_OR(&threads_want_sync, tid_bit) == tid_bit) if (HA_ATOMIC_OR(&threads_want_sync, tid_bit) == tid_bit)