From a70816da82ce84ba9792ba93313bdad46c1b8ec9 Mon Sep 17 00:00:00 2001 From: Amaury Denoyelle Date: Tue, 25 Nov 2025 15:46:14 +0100 Subject: [PATCH] BUG/MINOR: h3: handle properly buf alloc failure on response forwarding Replace BUG_ON() for buffer alloc failure on h3_resp_headers_to_htx() by proper error handling. An error status is reported which should be sufficient to initiate connection closure. No need to backport. --- src/h3.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/h3.c b/src/h3.c index 161d0a4c3..9ad5ff430 100644 --- a/src/h3.c +++ b/src/h3.c @@ -1150,8 +1150,11 @@ static ssize_t h3_resp_headers_to_htx(struct qcs *qcs, const struct buffer *buf, goto out; } - appbuf = qcc_get_stream_rxbuf(qcs); - BUG_ON(!appbuf); /* TODO */ + if (!(appbuf = qcc_get_stream_rxbuf(qcs))) { + TRACE_ERROR("buffer alloc failure", H3_EV_RX_FRAME|H3_EV_RX_HDR, qcs->qcc->conn, qcs); + len = -1; + goto out; + } BUG_ON(!b_size(appbuf)); /* TODO */ htx = htx_from_buf(appbuf);