mirrors/haproxy
1
0
Fork 0
mirror of https://git.haproxy.org/git/haproxy.git/ synced 2025-08-07 07:37:02 +02:00
Code Issues Projects Releases Wiki Activity

* TCP health-checks don't detect a connection refused with poll/epoll

Browse Source 
because event_srv_chk_r() is called before _w() and flushes the socket
  error. The result is that the server remains UP. The problem only
  affects pure TCP health-checks when select() is disabled. You may
  encounter this on SSL or SMTP proxies.
This commit is contained in:
willy tarreau 2005-12-18 01:39:19 +01:00
parent 48b06594b9
commit a4a583ac05
1 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
haproxy.c
View File

@ -2849,7 +2849,8 @@ int event_srv_chk_w(int fd) {
/* in case of TCP only, this tells us if the connection succeeded */ /* in case of TCP only, this tells us if the connection succeeded */
if (skerr) if (skerr)
s->result = -1; s->result = -1;
else { else if (s->result != -1) {
/* we don't want to mark 'UP' a server on which we detected an error earlier */
if (s->proxy->options & PR_O_HTTP_CHK) { if (s->proxy->options & PR_O_HTTP_CHK) {
int ret; int ret;
/* we want to check if this host replies to "OPTIONS / HTTP/1.0" /* we want to check if this host replies to "OPTIONS / HTTP/1.0"
@ -2886,11 +2887,11 @@ int event_srv_chk_w(int fd) {
*/ */
int event_srv_chk_r(int fd) { int event_srv_chk_r(int fd) {
char reply[64]; char reply[64];
int len; int len, result;
struct task *t = fdtab[fd].owner; struct task *t = fdtab[fd].owner;
struct server *s = t->context; struct server *s = t->context;
s->result = len = -1; result = len = -1;
#ifndef MSG_NOSIGNAL #ifndef MSG_NOSIGNAL
{ {
int skerr; int skerr;
@ -2910,7 +2911,10 @@ int event_srv_chk_r(int fd) {
if ((len >= sizeof("HTTP/1.0 000")) && if ((len >= sizeof("HTTP/1.0 000")) &&
!memcmp(reply, "HTTP/1.", 7) && !memcmp(reply, "HTTP/1.", 7) &&
(reply[9] == '2' || reply[9] == '3')) /* 2xx or 3xx */ (reply[9] == '2' || reply[9] == '3')) /* 2xx or 3xx */
s->result = 1; result = 1;
if (s->result != -1)
s->result = result;
FD_CLR(fd, StaticReadEvent); FD_CLR(fd, StaticReadEvent);
task_wakeup(&rq, t); task_wakeup(&rq, t);