mirrors/haproxy
1
0
Fork 0
mirror of https://git.haproxy.org/git/haproxy.git/ synced 2025-08-07 15:47:01 +02:00
Code Issues Projects Releases Wiki Activity

BUG/MINOR: quic: initialize msg_flags before sendmsg

Browse Source 
Previously, msghdr struct used for sendmsg was memset to 0. This was
updated for performance reason with each members individually defined.
This is done by the following commit :

  commit 107d6d7546
  OPTIM: quic: improve slightly qc_snd_buf() internal

msg_flags is the only member unset, as sendmsg manual page reports that
it is unused. However, this caused a coverity report. In the end, it is
better to explicitely set it to 0 to avoid any future interrogations,
compiler warning or even portability issues.

This should fix coverity report from github issue #2455.

No need to backport unless above patch is.
This commit is contained in:
Amaury Denoyelle 2024-02-21 10:05:14 +01:00
parent 9d572952a2
commit a17eaf7763
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/quic_sock.c
View File

@ -700,6 +700,7 @@ int qc_snd_buf(struct quic_conn *qc, const struct buffer *buf, size_t sz,
msg.msg_iovlen = 1; msg.msg_iovlen = 1;
msg.msg_control = NULL; msg.msg_control = NULL;
msg.msg_controllen = 0; msg.msg_controllen = 0;
msg.msg_flags = 0;
if (qc_test_fd(qc) && !fd_send_ready(qc->fd)) if (qc_test_fd(qc) && !fd_send_ready(qc->fd))
return 0; return 0;