mirrors/haproxy
1
0
Fork 0
mirror of https://git.haproxy.org/git/haproxy.git/ synced 2025-08-07 15:47:01 +02:00
Code Issues Projects Releases Wiki Activity

[MINOR] externalize the "balance" option parser to backend.c

Browse Source 
A new function "backend_parse_balance" has been created in backend.c,
which is dedicated to the parsing of the "balance" keyword. It will
provide easier methods for adding new algorithms.
This commit is contained in:
Willy Tarreau 2007-11-01 21:39:54 +01:00
parent 1a20a5d1b2
commit a0cbda61a7
3 changed files with 41 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
include/proto/backend.h
View File

@ -36,6 +36,8 @@ int connect_server(struct session *s);
int srv_count_retry_down(struct session *t, int conn_err); int srv_count_retry_down(struct session *t, int conn_err);
int srv_retryable_connect(struct session *t); int srv_retryable_connect(struct session *t);
int srv_redispatch_connect(struct session *t); int srv_redispatch_connect(struct session *t);
int backend_parse_balance(const char **args, char *err,
int errlen, struct proxy *curproxy);
void recount_servers(struct proxy *px); void recount_servers(struct proxy *px);
void recalc_server_map(struct proxy *px); void recalc_server_map(struct proxy *px);

36
src/backend.c
View File

@ -728,13 +728,47 @@ int srv_redispatch_connect(struct session *t)
} }
int be_downtime(struct proxy *px) { int be_downtime(struct proxy *px) {
if ((px->srv_act || px->srv_bck) && px->last_change < now.tv_sec) // ignore negative time if ((px->srv_act || px->srv_bck) && px->last_change < now.tv_sec) // ignore negative time
return px->down_time; return px->down_time;
return now.tv_sec - px->last_change + px->down_time; return now.tv_sec - px->last_change + px->down_time;
} }
/* This function parses a "balance" statement in a backend section describing
* <curproxy>. It returns -1 if there is any error, otherwise zero. If it
* returns -1, it may write an error message into ther <err> buffer, for at
* most <errlen> bytes, trailing zero included. The trailing '\n' will not be
* written. The function must be called with <args> pointing to the first word
* after "balance".
*/
int backend_parse_balance(const char **args, char *err, int errlen, struct proxy *curproxy)
{
if (!*(args[0])) {
/* if no option is set, use round-robin by default */
curproxy->options &= ~PR_O_BALANCE;
curproxy->options |= PR_O_BALANCE_RR;
return 0;
}
if (!strcmp(args[0], "roundrobin")) {
curproxy->options &= ~PR_O_BALANCE;
curproxy->options |= PR_O_BALANCE_RR;
}
else if (!strcmp(args[0], "source")) {
curproxy->options &= ~PR_O_BALANCE;
curproxy->options |= PR_O_BALANCE_SH;
}
else if (!strcmp(args[0], "uri")) {
curproxy->options &= ~PR_O_BALANCE;
curproxy->options |= PR_O_BALANCE_UH;
}
else {
snprintf(err, errlen, "'balance' only supports 'roundrobin', 'source' and 'uri' options.");
return -1;
}
return 0;
}
/* /*
* Local variables: * Local variables:
* c-indent-level: 8 * c-indent-level: 8

23
src/cfgparse.c
View File

@ -1326,29 +1326,12 @@ int cfg_parse_listen(const char *file, int linenum, char **args)
if (warnifnotcap(curproxy, PR_CAP_BE, file, linenum, args[0], NULL)) if (warnifnotcap(curproxy, PR_CAP_BE, file, linenum, args[0], NULL))
return 0; return 0;
if (*(args[1])) { memcpy(trash, "error near 'balance'", 19);
if (!strcmp(args[1], "roundrobin")) { if (backend_parse_balance((const char **)args + 1, trash, sizeof(trash), curproxy) < 0) {
curproxy->options &= ~PR_O_BALANCE; Alert("parsing [%s:%d] : %s\n", file, linenum, trash);
curproxy->options |= PR_O_BALANCE_RR;
}
else if (!strcmp(args[1], "source")) {
curproxy->options &= ~PR_O_BALANCE;
curproxy->options |= PR_O_BALANCE_SH;
}
else if (!strcmp(args[1], "uri")) {
curproxy->options &= ~PR_O_BALANCE;
curproxy->options |= PR_O_BALANCE_UH;
}
else {
Alert("parsing [%s:%d] : '%s' only supports 'roundrobin', 'source' and 'uri' options.\n", file, linenum, args[0]);
return -1; return -1;
} }
} }
else {/* if no option is set, use round-robin by default */
curproxy->options &= ~PR_O_BALANCE;
curproxy->options |= PR_O_BALANCE_RR;
}
}
else if (!strcmp(args[0], "server")) { /* server address */ else if (!strcmp(args[0], "server")) { /* server address */
int cur_arg; int cur_arg;
char *rport; char *rport;