From 9f7ce9e807cfbf056153bf91d9410b4c2ee375f5 Mon Sep 17 00:00:00 2001 From: Willy Tarreau Date: Thu, 11 Sep 2025 10:33:50 +0200 Subject: [PATCH] MINOR: activity: don't report the lat_tot column for show profiling tasks This column is pretty useless, as the total latency experienced by tasks is meaningless, what matters is the average per call. Since we'll add more columns and we need to keep all of this readable, let's get rid of this column. --- src/activity.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/activity.c b/src/activity.c index 1efd6281a..b06b48d68 100644 --- a/src/activity.c +++ b/src/activity.c @@ -990,7 +990,7 @@ static int cli_io_handler_show_profiling(struct appctx *appctx) if (!ctx->linenum) chunk_appendf(&trash, "Tasks activity over %.3f sec till %.3f sec ago:\n" - " function calls cpu_tot cpu_avg lat_tot lat_avg\n", + " function calls cpu_tot cpu_avg lat_avg\n", (prof_task_start_ns ? (prof_task_stop_ns ? prof_task_stop_ns : now_ns) - prof_task_start_ns : 0) / 1000000000.0, (prof_task_stop_ns ? now_ns - prof_task_stop_ns : 0) / 1000000000.0); @@ -1027,7 +1027,6 @@ static int cli_io_handler_show_profiling(struct appctx *appctx) print_time_short(&trash, " ", tmp_activity[i].cpu_time, ""); print_time_short(&trash, " ", tmp_activity[i].cpu_time / tmp_activity[i].calls, ""); - print_time_short(&trash, " ", tmp_activity[i].lat_time, ""); print_time_short(&trash, " ", tmp_activity[i].lat_time / tmp_activity[i].calls, ""); if (caller && !ctx->aggr && caller->what <= WAKEUP_TYPE_APPCTX_WAKEUP)