mirrors/haproxy
1
0
Fork 0
mirror of https://git.haproxy.org/git/haproxy.git/ synced 2025-08-06 07:07:04 +02:00
Code Issues Projects Releases Wiki Activity

BUG/MINOR: log: fix leak in add_sample_to_logformat_list() error path

Browse Source 
If add_sample_to_logformat_list() fails to allocate new logformat_node,
then we directly jump to error_free label to cleanup the node using
free_logformat_node() before returning an error.

However if the node failed to allocate, then the sample expression that
was allocated just before (not yet assigned) isn't released
(free_logformat_node() is a no-op when NULL is provided). Thus if expr
wasn't assigned to the node during early failure, then it must be manually
released.

This bug was introduced by 2462e5bcc ("BUG/MINOR: log: fix potential
lf->name memory leak") which wasn't marked for backports. It only
affects 3.0.
This commit is contained in:
Aurelien DARRAGON 2024-05-13 16:24:10 +02:00
parent cbe78c0281
commit 9d4a44e713
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/log.c
View File

@ -547,6 +547,7 @@ static int add_sample_to_logformat_list(char *text, char *name, int name_len, in
node = calloc(1, sizeof(*node)); node = calloc(1, sizeof(*node));
if (!node) { if (!node) {
release_sample_expr(expr);
memprintf(err, "out of memory error"); memprintf(err, "out of memory error");
goto error_free; goto error_free;
} }