mirrors/haproxy
1
0
Fork 0
mirror of https://git.haproxy.org/git/haproxy.git/ synced 2025-08-09 08:37:04 +02:00
Code Issues Projects Releases Wiki Activity

MINOR: connection: add a BUG_ON() to detect destroying connection in idle list

Browse Source 
Add a BUG_ON() in conn_free(), to check that when we're freeing a
connection, it is not still in the idle connections tree, otherwise the
next thread that will try to use it will probably crash.
This commit is contained in:
Olivier Houchard 2023-01-24 23:59:32 +01:00 committed by Willy Tarreau
parent 083b230699
commit 9a0f8ba837
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/connection.c
View File

@ -498,6 +498,10 @@ void conn_free(struct connection *conn)
pool_free(pool_head_uniqueid, istptr(conn->proxy_unique_id)); pool_free(pool_head_uniqueid, istptr(conn->proxy_unique_id));
conn->proxy_unique_id = IST_NULL; conn->proxy_unique_id = IST_NULL;
/* Make sure the connection is not left in the idle connection tree */
if (conn->hash_node != NULL)
BUG_ON(conn->hash_node->node.node.leaf_p != NULL);
pool_free(pool_head_conn_hash_node, conn->hash_node); pool_free(pool_head_conn_hash_node, conn->hash_node);
conn->hash_node = NULL; conn->hash_node = NULL;