mirrors/haproxy
1
0
Fork 0
mirror of https://git.haproxy.org/git/haproxy.git/ synced 2025-09-21 22:01:31 +02:00
Code Issues Projects Releases Wiki Activity

DEBUG: thread: report the spin lock counters as seek locks

Browse Source 
Technically speaking, spin locks use a seek lock, not a write lock,
so better count them appropriately for consistency (lock time, or
function calls count).
This commit is contained in:
Willy Tarreau 2025-02-10 08:02:42 +01:00
parent 7ddcdff33f
commit 99a88ee904
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/thread.c
View File

@ -938,9 +938,9 @@ void __spin_lock(enum lock_label lbl, struct ha_spinlock *l,
start_time = now_mono_time(); start_time = now_mono_time();
__SPIN_LOCK(&l->lock); __SPIN_LOCK(&l->lock);
HA_ATOMIC_ADD(&lock_stats[lbl].nsec_wait_for_write, (now_mono_time() - start_time)); HA_ATOMIC_ADD(&lock_stats[lbl].nsec_wait_for_seek, (now_mono_time() - start_time));
HA_ATOMIC_INC(&lock_stats[lbl].num_write_locked); HA_ATOMIC_INC(&lock_stats[lbl].num_seek_locked);
st->owner = tbit; st->owner = tbit;
@ -967,7 +967,7 @@ int __spin_trylock(enum lock_label lbl, struct ha_spinlock *l,
r = __SPIN_TRYLOCK(&l->lock); r = __SPIN_TRYLOCK(&l->lock);
if (unlikely(r)) if (unlikely(r))
return r; return r;
HA_ATOMIC_INC(&lock_stats[lbl].num_write_locked); HA_ATOMIC_INC(&lock_stats[lbl].num_seek_locked);
st->owner = tbit; st->owner = tbit;
l->info.last_location.function = func; l->info.last_location.function = func;
@ -994,7 +994,7 @@ void __spin_unlock(enum lock_label lbl, struct ha_spinlock *l,
l->info.last_location.line = line; l->info.last_location.line = line;
__SPIN_UNLOCK(&l->lock); __SPIN_UNLOCK(&l->lock);
HA_ATOMIC_INC(&lock_stats[lbl].num_write_unlocked); HA_ATOMIC_INC(&lock_stats[lbl].num_seek_unlocked);
} }
#endif // defined(DEBUG_THREAD) || defined(DEBUG_FULL) #endif // defined(DEBUG_THREAD) || defined(DEBUG_FULL)