From 99942d6f4c4dc91a2e5227a6915e789fd8c12331 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20L=C3=A9caille?= Date: Fri, 7 Jan 2022 14:32:31 +0100 Subject: [PATCH] MINOR: quic: Non-optimal use of a TX buffer When full, after having reset the writer index, let's reuse the TX buffer in any case. --- src/xprt_quic.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/src/xprt_quic.c b/src/xprt_quic.c index f1adc19a8..836e83f4c 100644 --- a/src/xprt_quic.c +++ b/src/xprt_quic.c @@ -2450,9 +2450,9 @@ static int qc_prep_pkts(struct quic_conn *qc, struct qring *qr, TRACE_ENTER(QUIC_EV_CONN_PHPKTS, qc); + total = 0; start: dglen = 0; - total = 0; padding = 0; qel = &qc->els[tel]; cbuf = qr->cbuf; @@ -2603,10 +2603,8 @@ static int qc_prep_pkts(struct quic_conn *qc, struct qring *qr, if (rd && rd <= cbuf->wr) { cb_wr_reset(cbuf); - if (pos == spos) { - /* Reuse the same buffer if nothing was built. */ - goto start; - } + /* Let's try to reuse this buffer */ + goto start; } }