mirrors/haproxy
1
0
Fork 0
mirror of https://git.haproxy.org/git/haproxy.git/ synced 2025-08-11 09:37:20 +02:00
Code Issues Projects Releases Wiki Activity

BUG/MINOR: cfgparse-quic: fix warning for cc-aglo with 0 burst

Browse Source 
Optional burst argument for quic-cc-algo is used to toggle pacing
support on top of cubic. This is the case if it is positive.

The default value is 0, which do not activate pacing. However, in this
case, an incorrect warning is reported about the parameter being
ignored. Fix this by removing the warning in this case.

No need to backport.
This commit is contained in:
Amaury Denoyelle 2024-11-21 11:15:47 +01:00
parent ea17de01ac
commit 99497d23b5
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/cfgparse-quic.c
View File

@ -188,7 +188,11 @@ static int bind_parse_quic_cc_algo(char **args, int cur_arg, struct proxy *px,
if (burst < 0) if (burst < 0)
goto fail; goto fail;
if (burst && cc_algo->type == QUIC_CC_ALGO_TP_CUBIC) { if (cc_algo->type != QUIC_CC_ALGO_TP_CUBIC) {
ha_warning("'%s' : burst parameter ignored for '%s' congestion algorithm\n",
args[cur_arg], algo);
}
else if (burst) {
if (!experimental_directives_allowed) { if (!experimental_directives_allowed) {
memprintf(err, "'%s' : support for pacing is experimental, must be allowed via a global " memprintf(err, "'%s' : support for pacing is experimental, must be allowed via a global "
"'expose-experimental-directives'\n", args[cur_arg]); "'expose-experimental-directives'\n", args[cur_arg]);
@ -199,10 +203,6 @@ static int bind_parse_quic_cc_algo(char **args, int cur_arg, struct proxy *px,
cc_algo->pacing_rate = quic_cc_default_pacing_rate; cc_algo->pacing_rate = quic_cc_default_pacing_rate;
cc_algo->pacing_burst = quic_cc_default_pacing_burst; cc_algo->pacing_burst = quic_cc_default_pacing_burst;
} }
else {
ha_warning("'%s' : burst parameter ignored for '%s' congestion algorithm\n",
args[cur_arg], algo);
}
if (*end_opt == ')') { if (*end_opt == ')') {
goto out; goto out;