mirrors/haproxy
1
0
Fork 0
mirror of https://git.haproxy.org/git/haproxy.git/ synced 2025-11-18 17:31:30 +01:00
Code Issues Projects Releases Wiki Activity

BUG/MINOR: tcp: don't try to set defaultmss when value is negative

Browse Source 
when `getsockopt` previously failed, we were trying to set defaultmss
with -2 value.

this is a followup of github issue #499

this should be backported to all versions >= v1.8

Fixes: 153659f1ae69a1 ("MINOR: tcp: When binding socket, attempt to
reuse one from the old proc.")
Signed-off-by: William Dauchy <w.dauchy@criteo.com>
This commit is contained in:
William Dauchy 2020-02-12 15:53:04 +01:00 committed by Willy Tarreau
parent 47e09dd034
commit 97a7bdac3e
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/proto_tcp.c
View File

@ -906,9 +906,9 @@ int tcp_bind_listener(struct listener *listener, char *errmsg, int errlen)
defaultmss = default_tcp6_maxseg; defaultmss = default_tcp6_maxseg;
getsockopt(fd, IPPROTO_TCP, TCP_MAXSEG, &tmpmaxseg, &len); getsockopt(fd, IPPROTO_TCP, TCP_MAXSEG, &tmpmaxseg, &len);
if (tmpmaxseg != defaultmss && setsockopt(fd, IPPROTO_TCP, if (defaultmss > 0 &&
TCP_MAXSEG, &defaultmss, tmpmaxseg != defaultmss &&
sizeof(defaultmss)) == -1) { setsockopt(fd, IPPROTO_TCP, TCP_MAXSEG, &defaultmss, sizeof(defaultmss)) == -1) {
msg = "cannot set MSS"; msg = "cannot set MSS";
err |= ERR_WARN; err |= ERR_WARN;
} }