mirrors/haproxy
1
0
Fork 0
mirror of https://git.haproxy.org/git/haproxy.git/ synced 2026-05-04 20:46:11 +02:00
Code Issues Projects Releases Wiki Activity

MINOR: stream: report the list of active filters on stream crashes

Browse Source 
Now we very rarely catch spinning streams, and whenever we catch one it
seems a filter is involved, but we currently report no info about them.
Let's print the list of enabled filters on the stream with such a crash
to help with the reports. A typical output will now look like this:

  [ALERT] 121/165908 (1110) : A bogus STREAM [0x7fcaf4016a60] is spinning at 2 calls per second and refuses to die, aborting now! Please report this error to developers [strm=0x7fcaf4016a60 src=127.0.0.1 fe=l1 be=l1 dst=<CACHE> rqf=6dc42000 rqa=48000 rpf=a0040223 rpa=24000000 sif=EST,10008 sib=DIS,80110 af=(nil),0 csf=0x7fcaf4023c00,10c000 ab=0x7fcaf40235f0,4 csb=(nil),0 cof=0x7fcaf4016610,1300:H1(0x7fcaf4016840)/RAW((nil))/tcpv4(29) cob=(nil),0:NONE((nil))/NONE((nil))/NONE(0) filters={0x7fcaf4016fb0="cache store filter", 0x7fcaf4017080="compression filter"}]

This may be backported to 2.0.
This commit is contained in:
Willy Tarreau 2020-05-01 16:57:02 +02:00
parent 86c6a9221a
commit 9753d61288
1 changed files with 13 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/stream.c
View File

@ -2666,6 +2666,19 @@ void stream_dump_and_crash(enum obj_type *obj, int rate)
chunk_reset(&trash);
stream_dump(&trash, s, "", ' ');
chunk_appendf(&trash, "filters={");
if (HAS_FILTERS(s)) {
struct filter *filter;
list_for_each_entry(filter, &s->strm_flt.filters, list) {
if (filter->list.p != &s->strm_flt.filters)
chunk_appendf(&trash, ", ");
chunk_appendf(&trash, "%p=\"%s\"", filter, FLT_ID(filter));
}
}
chunk_appendf(&trash, "}");
memprintf(&msg,
"A bogus %s [%p] is spinning at %d calls per second and refuses to die, "
"aborting now! Please report this error to developers "