BUG/MEDIUM: mux-h2: fix crash on idle-ping due to unwanted ABORT_NOW

An ABORT_NOW() was used during debugging idle-ping but was not removed
from the final code. This may cause crash, in particular when mixing
idle-ping with shorter http-request/http-keep-alive values.

Fix this situation by removing ABORT_NOW() statement.

This should fix github issue #3079.

This must be backported up to 3.2.
This commit is contained in:
Amaury Denoyelle 2025-08-21 14:16:58 +02:00
parent 82b002a225
commit 901de11157

View File

@ -924,7 +924,6 @@ static void h2c_update_timeout(struct h2c *h2c)
else if (h2c->flags & H2_CF_IDL_PING_SENT) { else if (h2c->flags & H2_CF_IDL_PING_SENT) {
/* timer other than ping selected, remove ping flag to allow GOAWAY on expiration. */ /* timer other than ping selected, remove ping flag to allow GOAWAY on expiration. */
h2c->flags &= ~H2_CF_IDL_PING_SENT; h2c->flags &= ~H2_CF_IDL_PING_SENT;
ABORT_NOW();
} }
} }
} }