From 90126ec9b733694d4c5ad0f20c221cff639db95f Mon Sep 17 00:00:00 2001 From: Frederic Lecaille Date: Mon, 1 Sep 2025 09:29:16 +0200 Subject: [PATCH] CLEANUP: quic: remove a useless CRYPTO frame variable assignment This modification should have arrived with this commit: MINOR: quic: remove ->offset qf_crypto struct field Since this commit, the CRYPTO offset node key assignment is done at parsing time when calling qc_parse_frm() from qc_parse_pkt_frms(). This useless assigment has been reported in GH #3095 by coverity. This patch should be easily backported as far as 2.6 as the one mentioned above to ease any further backport to come. --- src/quic_rx.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/quic_rx.c b/src/quic_rx.c index 66b607cb4..08318763f 100644 --- a/src/quic_rx.c +++ b/src/quic_rx.c @@ -903,7 +903,6 @@ static int qc_parse_pkt_frms(struct quic_conn *qc, struct quic_rx_packet *pkt, break; } case QUIC_FT_CRYPTO: - frm->crypto.offset_node.key = frm->crypto.offset_node.key; eb64_insert(&cf_frms_tree, &frm->crypto.offset_node); frm = NULL; break;