mirrors/haproxy
1
0
Fork 0
mirror of https://git.haproxy.org/git/haproxy.git/ synced 2025-09-25 07:41:36 +02:00
Code Issues Projects Releases Wiki Activity

BUG/MINOR: quic: Wrong initialization for io_cb_wakeup boolean

Browse Source 
This bug arrives with this commit:
    982896961 MINOR: quic: split and rename qc_lstnr_pkt_rcv()
The first block of code consists in possibly setting this variable to true.
But it was already initialized to true before entering this code section.
Should be initialized to false.

Also take the opportunity to remove an unused "err" label.

Must be backported to 2.6 and 2.7.
This commit is contained in:
Frédéric Lécaille 2023-02-15 11:55:21 +01:00 committed by Amaury Denoyelle
parent 7c6d8f88df
commit 8f7d22406c
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/quic_conn.c
View File

@ -6589,7 +6589,7 @@ static void qc_rx_pkt_handle(struct quic_conn *qc, struct quic_rx_packet *pkt,
const struct quic_version *qv = pkt->version;
struct quic_enc_level *qel = NULL;
size_t b_cspace;
int io_cb_wakeup = 1;
int io_cb_wakeup = 0;
TRACE_ENTER(QUIC_EV_CONN_LPKT, qc, pkt, NULL, qv);
@ -6657,7 +6657,6 @@ static void qc_rx_pkt_handle(struct quic_conn *qc, struct quic_rx_packet *pkt,
drop:
HA_ATOMIC_INC(&qc->prx_counters->dropped_pkt);
err:
if (io_cb_wakeup) {
TRACE_DEVEL("needs to wakeup the timer task after the amplification limit was reached",
QUIC_EV_CONN_LPKT, qc);