From 8f1f1b05795f7114c5bbb0cf3bffdf86ed299370 Mon Sep 17 00:00:00 2001 From: Christopher Faulet Date: Thu, 15 Dec 2022 09:59:50 +0100 Subject: [PATCH] BUG/MINOR: mux-h1: Fix test instead a BUG_ON() in h1_send_error() In the previous patch (86924532db "BUG/MINOR: mux-h1: Fix test instead a BUG_ON() in h1_send_error()"), a BUG_ON() condition was inverted by error in h1_send_error(). The stream-connector must be NULL to be able to destroy the H1 stream. This patch must be backported with the commit above (to 2.7). --- src/mux_h1.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mux_h1.c b/src/mux_h1.c index c511cfede..fb1363bc0 100644 --- a/src/mux_h1.c +++ b/src/mux_h1.c @@ -2630,7 +2630,7 @@ static int h1_send_error(struct h1c *h1c) } if (h1c->state == H1_CS_EMBRYONIC) { - BUG_ON(h1c->h1s == NULL || h1s_sc(h1c->h1s) == NULL); + BUG_ON(h1c->h1s == NULL || h1s_sc(h1c->h1s) != NULL); TRACE_DEVEL("Abort embryonic H1S", H1_EV_H1C_ERR, h1c->conn, h1c->h1s); h1s_destroy(h1c->h1s); }