mirrors/haproxy
1
0
Fork 0
mirror of https://git.haproxy.org/git/haproxy.git/ synced 2025-11-14 15:31:00 +01:00
Code Issues Projects Releases Wiki Activity

DEBUG: applet: instrument appctx_wakeup() to log the caller's location

Browse Source 
appctx_wakeup() relies on task_wakeup(), but since it calls it from a
function, the calling place is always appctx_wakeup() itself, which is
not very useful.

Let's turn it to a macro so that we can log the location of the caller
instead. As an example, the cli_io_handler() which used to be seen as
this:

  (gdb) p *appctx->t.debug.caller[0]
  $10 = {
    func = 0x9ffb78 <__func__.37996> "appctx_wakeup",
    file = 0x9b336a "include/haproxy/applet.h",
    line = 110,
    what = 1 '\001',
    arg8 = 0 '\000',
    arg32 = 0
  }

Now shows the more useful:

  (gdb) p *appctx->t.debug.caller[0]
  $6 = {
    func = 0x9ffe80 <__func__.38641> "sc_app_chk_snd_applet",
    file = 0xa00320 "src/stconn.c",
    line = 996,
    what = 6 '\006',
    arg8 = 0 '\000',
    arg32 = 0
  }
This commit is contained in:
Willy Tarreau 2022-09-06 14:45:55 +02:00
parent e08af9a0f4
commit 8d71abf0cd
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
include/haproxy/applet.h
View File

@ -104,11 +104,11 @@ static inline void appctx_free(struct appctx *appctx)
} }
} }
/* wakes up an applet when conditions have changed */ /* wakes up an applet when conditions have changed. We're using a macro here in
static inline void appctx_wakeup(struct appctx *appctx) * order to retrieve the caller's place.
{ */
task_wakeup(appctx->t, TASK_WOKEN_OTHER); #define appctx_wakeup(ctx) \
} _task_wakeup((ctx)->t, TASK_WOKEN_OTHER, MK_CALLER(WAKEUP_TYPE_APPCTX_WAKEUP, 0, 0))
/* returns the stream connector the appctx is attached to, via the sedesc */ /* returns the stream connector the appctx is attached to, via the sedesc */
static inline struct stconn *appctx_sc(const struct appctx *appctx) static inline struct stconn *appctx_sc(const struct appctx *appctx)