mirrors/haproxy
1
0
Fork 0
mirror of https://git.haproxy.org/git/haproxy.git/ synced 2025-08-06 07:07:04 +02:00
Code Issues Projects Releases Wiki Activity

MINOR: task/thread: factor out a wake-up condition

Browse Source 
The wakeup condition in task_wakeup() is redundant as it is already
validated by the CAS. Better move the __task_wakeup() call there, it
also has the merit of being easier to audit this way. This also reduces
the code size by around 1.8 kB :

  $ size haproxy-?
     text    data     bss     dec     hex filename
  2153806  100208 1307676 3561690  3658da haproxy-1
  2152094  100208 1307676 3559978  36522a haproxy-2
This commit is contained in:
Willy Tarreau 2019-04-17 20:52:51 +02:00
parent a70bfaaf8b
commit 8c12e2f785
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
include/proto/task.h
View File

@ -153,11 +153,11 @@ static inline void task_wakeup(struct task *t, unsigned int f)
state = _HA_ATOMIC_OR(&t->state, f);
while (!(state & (TASK_RUNNING | TASK_QUEUED))) {
if (_HA_ATOMIC_CAS(&t->state, &state, state | TASK_QUEUED))
if (_HA_ATOMIC_CAS(&t->state, &state, state | TASK_QUEUED)) {
__task_wakeup(t, root);
break;
}
}
if (!(state & (TASK_QUEUED | TASK_RUNNING)))
__task_wakeup(t, root);
}
/* change the thread affinity of a task to <thread_mask> */