mirrors/haproxy
1
0
Fork 0
mirror of https://git.haproxy.org/git/haproxy.git/ synced 2025-08-07 15:47:01 +02:00
Code Issues Projects Releases Wiki Activity

MEDIUM: checks: Stop scheduling healthchecks during stopping stage

Browse Source 
When the process is stopping, the health-checks are suspended. However the
task is still periodically woken up for nothing. If there is a huge number
of health-checks and if they are woken up in same time, it may lead to a
noticeable CPU consumption for no reason.

To avoid this extra CPU cost, we stop to schedule the health-check tasks
when the proxy is disabled or stopped.

This patch should partially solve the issue #2145.
This commit is contained in:
Christopher Faulet 2023-05-16 18:07:51 +02:00
parent 8a46f98615
commit 8bca3cc8c7
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/check.c
View File

@ -1327,8 +1327,13 @@ struct task *process_chk_conn(struct task *t, void *context, unsigned int state)
} }
reschedule: reschedule:
while (tick_is_expired(t->expire, now_ms)) if (proxy->flags & (PR_FL_DISABLED|PR_FL_STOPPED))
t->expire = tick_add(t->expire, MS_TO_TICKS(check->inter)); t->expire = TICK_ETERNITY;
else {
while (tick_is_expired(t->expire, now_ms))
t->expire = tick_add(t->expire, MS_TO_TICKS(check->inter));
}
out_unlock: out_unlock:
if (check->server) if (check->server)
HA_SPIN_UNLOCK(SERVER_LOCK, &check->server->lock); HA_SPIN_UNLOCK(SERVER_LOCK, &check->server->lock);