mirrors/haproxy
1
0
Fork 0
mirror of https://git.haproxy.org/git/haproxy.git/ synced 2025-09-24 23:31:40 +02:00
Code Issues Projects Releases Wiki Activity

BUG/MINOR: quic: ignore congestion window on probing for MUX wakeup

Browse Source 
qc_notify_send() is used to wake up the MUX layer for sending. This
function first ensures that all sending condition are met to avoid to
wake up the MUX for unnecessarily.

One of this condition is to check if there is room in the congestion
window. However, when probe packets must be sent due to a PTO
expiration, RFC 9002 explicitely mentions that the congestion window
must be ignored which was not the case prior to this patch.

This commit fixes this by first setting <pto_probe> of 01RTT packet
space before invoking qc_notify_send(). This ensures that congestion
window won't be checked anymore to wake up the MUX layer until probing
packets are sent.

This commit replaces the following one which was not sufficient :
  commit e25fce03ebe3307bc104d1f81356108e271d2bc3
  BUG/MINOR: quic: Dysfunctional 01RTT packet number space probing

This should be backported up to 2.7.
This commit is contained in:
Amaury Denoyelle 2023-03-21 11:39:24 +01:00
parent 2a19b6e564
commit 8afe4b88c4
1 changed files with 11 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/quic_conn.c
View File

@ -5188,6 +5188,7 @@ struct task *qc_process_timer(struct task *task, void *ctx, unsigned int state)
} }
} }
else if (pktns == &qc->pktns[QUIC_TLS_PKTNS_01RTT]) { else if (pktns == &qc->pktns[QUIC_TLS_PKTNS_01RTT]) {
pktns->tx.pto_probe = QUIC_MAX_NB_PTO_DGRAMS;
/* Wake up upper layer if waiting to send new data. */ /* Wake up upper layer if waiting to send new data. */
if (!qc_notify_send(qc)) { if (!qc_notify_send(qc)) {
TRACE_STATE("needs to probe 01RTT packet number space", QUIC_EV_CONN_TXPKT, qc); TRACE_STATE("needs to probe 01RTT packet number space", QUIC_EV_CONN_TXPKT, qc);
@ -8107,14 +8108,22 @@ void qc_notify_close(struct quic_conn *qc)
TRACE_LEAVE(QUIC_EV_CONN_CLOSE, qc); TRACE_LEAVE(QUIC_EV_CONN_CLOSE, qc);
} }
/* Wake-up upper layer if waiting for send to be ready. /* Wake-up upper layer for sending if all conditions are met :
* - room in congestion window or probe packet to sent
* - socket FD ready to sent or listener socket used
* *
* Returns 1 if upper layer has been woken up else 0. * Returns 1 if upper layer has been woken up else 0.
*/ */
int qc_notify_send(struct quic_conn *qc) int qc_notify_send(struct quic_conn *qc)
{ {
const struct quic_pktns *pktns = &qc->pktns[QUIC_TLS_PKTNS_01RTT];
if (qc->subs && qc->subs->events & SUB_RETRY_SEND) { if (qc->subs && qc->subs->events & SUB_RETRY_SEND) {
if (quic_path_prep_data(qc->path) && /* RFC 9002 7.5. Probe Timeout
*
* Probe packets MUST NOT be blocked by the congestion controller.
*/
if ((quic_path_prep_data(qc->path) || pktns->tx.pto_probe) &&
(!qc_test_fd(qc) || !fd_send_active(qc->fd))) { (!qc_test_fd(qc) || !fd_send_active(qc->fd))) {
tasklet_wakeup(qc->subs->tasklet); tasklet_wakeup(qc->subs->tasklet);
qc->subs->events &= ~SUB_RETRY_SEND; qc->subs->events &= ~SUB_RETRY_SEND;