From 8939d8e4738e525d809fafff39f9c5b5051ee00c Mon Sep 17 00:00:00 2001 From: Amaury Denoyelle Date: Thu, 8 Aug 2024 09:30:40 +0200 Subject: [PATCH] MINOR: mux-quic: do not trace error in qcc_send_frames() on empty list qcc_send_frames() can be called with an empty list and returns immediately with an error code. This is convenience to be able to call it in a while loop. Remove the trace with "error" when this is the case and replacing it with a less alarming "leaving on..." message. This should help debugging when traces are active. --- src/mux_quic.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mux_quic.c b/src/mux_quic.c index 81cfa7a05..8755f742a 100644 --- a/src/mux_quic.c +++ b/src/mux_quic.c @@ -1966,8 +1966,8 @@ static int qcc_send_frames(struct qcc *qcc, struct list *frms) TRACE_ENTER(QMUX_EV_QCC_SEND, qcc->conn); if (LIST_ISEMPTY(frms)) { - TRACE_DEVEL("no frames to send", QMUX_EV_QCC_SEND, qcc->conn); - goto err; + TRACE_DEVEL("leaving on no frame to send", QMUX_EV_QCC_SEND, qcc->conn); + return 1; } if (!qc_send_mux(qcc->conn->handle.qc, frms)) {