mirrors/haproxy
1
0
Fork 0
mirror of https://git.haproxy.org/git/haproxy.git/ synced 2025-09-25 15:51:24 +02:00
Code Issues Projects Releases Wiki Activity

BUG/MINOR: ssl: report the L4 connection as established when possible

Browse Source 
If we get an SSL error during the handshake, we at least try to see
if a syscall reported an error or not. In case of an error, it generally
means that the connection failed. If there is no error, then the connection
established successfully.

The difference is important for health checks which report the precise cause
to the logs and to the stats.
This commit is contained in:
Willy Tarreau 2012-09-28 20:22:13 +02:00
parent 051cdab68b
commit 8923019a1d
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/ssl_sock.c
View File

@ -720,6 +720,12 @@ int ssl_sock_handshake(struct connection *conn, unsigned int flag)
__conn_sock_poll_recv(conn);
return 0;
}
else if (ret == SSL_ERROR_SYSCALL) {
/* if errno is null, then connection was successfully established */
if (!errno && conn->flags & CO_FL_WAIT_L4_CONN)
conn->flags &= ~CO_FL_WAIT_L4_CONN;
goto out_error;
}
else {
/* Fail on all other handshake errors */
goto out_error;