mirrors/haproxy
1
0
Fork 0
mirror of https://git.haproxy.org/git/haproxy.git/ synced 2025-10-27 22:51:02 +01:00
Code Issues Projects Releases Wiki Activity

MINOR: sched: let's permit to share the local ctx between threads

Browse Source 
The watchdog timer has to go through complex operations due to not being
able to check if another thread's scheduler is still ticking. This is
simply because the scheduler status is marked as thread-local while it
could in fact also be an array. Let's do that (and align the array to
avoid false sharing) so that it's now possible to check any scheduler's
status.
This commit is contained in:
Willy Tarreau 2025-09-30 18:56:41 +02:00
parent 21ae35dd29
commit 7c7e17a605
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/task.c
View File

@ -43,7 +43,9 @@ DECLARE_TYPED_POOL(pool_head_notification, "notification", struct notification);
__decl_aligned_rwlock(wq_lock);
/* used to detect if the scheduler looks stuck (for warnings) */
static THREAD_LOCAL int sched_stuck;
static struct {
int sched_stuck ALIGNED(64);
} sched_ctx[MAX_THREADS];
/* Flags the task <t> for immediate destruction and puts it into its first
* thread's shared tasklet list if not yet queued/running. This will bypass
@ -677,7 +679,7 @@ unsigned int run_tasks_from_lists(unsigned int budgets[])
done++;
next:
th_ctx->current = NULL;
sched_stuck = 0; // scheduler is not stuck (don't warn)
sched_ctx[tid].sched_stuck = 0; // scheduler is not stuck (don't warn)
__ha_barrier_store();
/* stats are only registered for non-zero wake dates */
@ -914,11 +916,11 @@ void process_runnable_tasks()
*/
int is_sched_alive(void)
{
if (sched_stuck)
if (sched_ctx[tid].sched_stuck)
return 0;
/* next time we'll know if any progress was made */
sched_stuck = 1;
sched_ctx[tid].sched_stuck = 1;
return 1;
}