mirrors/haproxy
1
0
Fork 0
mirror of https://git.haproxy.org/git/haproxy.git/ synced 2025-08-07 23:56:57 +02:00
Code Issues Projects Releases Wiki Activity

MINOR: quic: Warning for OpenSSL wrapper QUIC bindings without "limited-quic"

Browse Source 
If the "limited-quic" globale option wa not set, the QUIC listener bindings were
not bound, this is ok, but silently ignored.

Add a warning in these cases to ask the user to explicitely enable the QUIC
bindings when building QUIC support against a TLS/SSL library without QUIC
support (OpenSSL).
This commit is contained in:
Frédéric Lécaille 2023-08-08 11:41:13 +02:00
parent ab95230200
commit 7c730803dc
1 changed files with 13 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
src/protocol.c
View File

@ -118,13 +118,22 @@ int protocol_supports_flag(struct protocol *proto, uint flag)
/* Return 1 if QUIC protocol may be bound, 0 if no, depending on the tuning /* Return 1 if QUIC protocol may be bound, 0 if no, depending on the tuning
* parameters. * parameters.
*/ */
static inline int protocol_may_bind_quic(void) static inline int protocol_may_bind_quic(struct listener *l)
{ {
#ifdef USE_QUIC_OPENSSL_COMPAT
struct proxy *px = l->bind_conf->frontend;
#endif
if (global.tune.options & GTUNE_NO_QUIC) if (global.tune.options & GTUNE_NO_QUIC)
return 0; return 0;
#ifdef USE_QUIC_OPENSSL_COMPAT #ifdef USE_QUIC_OPENSSL_COMPAT
if (!(global.tune.options & GTUNE_LIMITED_QUIC)) if (!(global.tune.options & GTUNE_LIMITED_QUIC)) {
ha_warning("Binding [%s:%d] for %s %s: receiving socket not bound"
" (\"limited-quic\" global option is not set)\n",
l->bind_conf->file, l->bind_conf->line,
proxy_type_str(px), px->id);
return 0; return 0;
}
#endif #endif
return 1; return 1;
} }
@ -146,12 +155,12 @@ int protocol_bind_all(int verbose)
HA_SPIN_LOCK(PROTO_LOCK, &proto_lock); HA_SPIN_LOCK(PROTO_LOCK, &proto_lock);
list_for_each_entry(proto, &protocols, list) { list_for_each_entry(proto, &protocols, list) {
list_for_each_entry(receiver, &proto->receivers, proto_list) { list_for_each_entry(receiver, &proto->receivers, proto_list) {
listener = LIST_ELEM(receiver, struct listener *, rx);
#ifdef USE_QUIC #ifdef USE_QUIC
if ((proto == &proto_quic4 || proto == &proto_quic6) && if ((proto == &proto_quic4 || proto == &proto_quic6) &&
!protocol_may_bind_quic()) !protocol_may_bind_quic(listener))
continue; continue;
#endif #endif
listener = LIST_ELEM(receiver, struct listener *, rx);
lerr = proto->fam->bind(receiver, &errmsg); lerr = proto->fam->bind(receiver, &errmsg);
err |= lerr; err |= lerr;