mirrors/haproxy
1
0
Fork 0
mirror of https://git.haproxy.org/git/haproxy.git/ synced 2025-09-28 17:21:32 +02:00
Code Issues Projects Releases Wiki Activity

BUG/MINOR: cfgparse-quic: fix bbr initialization

Browse Source 
To support pacing with cubic, a recent change was introduced to render
quic_cc_algo on bind line dynamically allocated, instead of pointing to
a globally defined variable. This allows customization of the algorithm
callbacks per bind line.

This was not correctly used for BBR as it was set to point to the global
quic_cc_algo_bbr. This causes a segfault on haproxy process closing. Fix
this by properly initializing BBR as other algorithms.

This should fix coverity report from github issue #2786.
This commit is contained in:
Amaury Denoyelle 2024-11-21 10:24:34 +01:00
parent e58a30d369
commit 7b23c9075c
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/cfgparse-quic.c
View File

@ -151,7 +151,7 @@ static int bind_parse_quic_cc_algo(char **args, int cur_arg, struct proxy *px,
/* bbr */ /* bbr */
algo = QUIC_CC_BBR_STR; algo = QUIC_CC_BBR_STR;
cc_algo = &quic_cc_algo_bbr; *cc_algo = quic_cc_algo_bbr;
arg += strlen(QUIC_CC_BBR_STR); arg += strlen(QUIC_CC_BBR_STR);
} }
else if (strncmp(arg, QUIC_CC_NO_CC_STR, strlen(QUIC_CC_NO_CC_STR)) == 0) { else if (strncmp(arg, QUIC_CC_NO_CC_STR, strlen(QUIC_CC_NO_CC_STR)) == 0) {