From 78b1eb2b04f01584e838abfcd8512f02364abba0 Mon Sep 17 00:00:00 2001 From: Christopher Faulet Date: Wed, 24 May 2023 11:44:53 +0200 Subject: [PATCH] BUG/MINOR: mux-h2: Check H2_SF_BODY_TUNNEL on H2S flags and not demux frame ones In h2c_frt_stream_new(), H2_SF_BODY_TUNNEL flags was tested on demux frame flags (h2c->dff) instead of the h2s flags. By chance, it is a noop test becasue H2_SF_BODY_TUNNEL value, once converted to an int8_t, is 0. It is a 2.8-specific issue. No backport needed. --- src/mux_h2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mux_h2.c b/src/mux_h2.c index b7d283484..61dc97281 100644 --- a/src/mux_h2.c +++ b/src/mux_h2.c @@ -1570,7 +1570,7 @@ static struct h2s *h2c_frt_stream_new(struct h2c *h2c, int id, struct buffer *in /* The request is not finished, don't expect data from the opposite side * yet */ - if (!(h2c->dff & (H2_F_HEADERS_END_STREAM| H2_F_DATA_END_STREAM|H2_SF_BODY_TUNNEL))) + if (!(h2c->dff & (H2_F_HEADERS_END_STREAM| H2_F_DATA_END_STREAM)) && !(flags & H2_SF_BODY_TUNNEL)) se_expect_no_data(h2s->sd); /* FIXME wrong analogy between ext-connect and websocket, this need to