mirrors/haproxy
1
0
Fork 0
mirror of https://git.haproxy.org/git/haproxy.git/ synced 2025-12-14 14:11:00 +01:00
Code Issues Projects Releases Wiki Activity

MEDIUM: stick-tables: Stop if stktable_trash_oldest() fails.

Browse Source 
In stksess_new(), if the table is full, we call stktable_trash_oldest()
to remove a few entries so that we have some room for a new one.
It is unlikely, but possible, that stktable_trash_oldest() will fail. If
so, just give up and do not add the new entry, instead of adding it
anyway.
Give up if stktable_trash_oldest() fails to free any entry
This commit is contained in:
Olivier Houchard 2025-10-14 18:51:32 +02:00 committed by Olivier Houchard
parent d5562e31bd
commit 7854331c71
1 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/stick_table.c
View File

@ -443,11 +443,13 @@ struct stksess *stksess_new(struct stktable *t, struct stktable_key *key)
HA_ATOMIC_DEC(&t->current); HA_ATOMIC_DEC(&t->current);
return NULL; return NULL;
} }
/* note that it may fail to find any releasable slot due to if (stktable_trash_oldest(t) < 1) {
* locking contention but it's not a problem in practice, /*
* these will be recovered later. * If we did not manage to purge any entry, give up.
*/ */
stktable_trash_oldest(t); HA_ATOMIC_DEC(&t->current);
return NULL;
}
} }
ts = pool_alloc(t->pool); ts = pool_alloc(t->pool);