From 75ae0f7bbc08e8b39ab75bf08f32f306ad6f0fc9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20L=C3=A9caille?= Date: Wed, 28 Jun 2023 18:28:51 +0200 Subject: [PATCH] CLEANUP: quic: Remove a useless test about discarded pktns (qc_handle_crypto_frm()) There is no need to check that the packet number space associated to the encryption level to handle the CRYPTO frames is available when entering qc_handle_crypto_frm(). This has already been done by the caller: qc_treat_rx_pkts(). --- src/quic_conn.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/src/quic_conn.c b/src/quic_conn.c index 2927058da..a3b4d3ffe 100644 --- a/src/quic_conn.c +++ b/src/quic_conn.c @@ -2936,11 +2936,6 @@ static int qc_handle_crypto_frm(struct quic_conn *qc, struct ncbuf *ncbuf = &qel->cstream->rx.ncbuf; TRACE_ENTER(QUIC_EV_CONN_PRSHPKT, qc); - if (unlikely(qel->tls_ctx.flags & QUIC_FL_TLS_SECRETS_DCD)) { - TRACE_PROTO("CRYPTO data discarded", - QUIC_EV_CONN_RXPKT, qc, pkt, &cfdebug); - goto done; - } if (unlikely(crypto_frm->offset < cstream->rx.offset)) { size_t diff;