mirrors/haproxy
1
0
Fork 0
mirror of https://git.haproxy.org/git/haproxy.git/ synced 2026-05-04 20:46:11 +02:00
Code Issues Projects Releases Wiki Activity

MEDIUM: epoll: Make sure we can add a new event

Browse Source 
Check that the call to epoll_ctl() succeeds, and if it does not, if
we're adding a new event and it fails with EEXIST, then delete and
re-add the event. There are a few cases where we may already have events
for a fd. If epoll_ctl() fails for any reason, use BUG_ON to make sure
we immediately crash, as this should not happen.
This commit is contained in:
Olivier Houchard 2025-02-25 12:01:40 +01:00 committed by Olivier Houchard
parent c5cc09c00d
commit 752c5cba5d
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/ev_epoll.c
View File

@ -154,7 +154,14 @@ static void _update_fd(int fd)
done:
ev.events &= ~epoll_mask;
ev.data.u64 = ((u64)fdtab[fd].generation << 32) + fd;
epoll_ctl(epoll_fd[tid], opcode, fd, &ev);
if (epoll_ctl(epoll_fd[tid], opcode, fd, &ev) != 0) {
if (opcode == EPOLL_CTL_ADD && errno == EEXIST) {
BUG_ON(epoll_ctl(epoll_fd[tid], EPOLL_CTL_DEL, fd, &ev) != 0);
BUG_ON(epoll_ctl(epoll_fd[tid], EPOLL_CTL_ADD, fd, &ev) != 0);
} else {
BUG_ON(1, "epoll_ctl() failed when it should not");
}
}
}
/*