From 74a5a9828b7eba80248573e110bc8ed388d8b692 Mon Sep 17 00:00:00 2001 From: Willy Tarreau Date: Thu, 24 Nov 2016 15:25:39 +0100 Subject: [PATCH] BUG/MINOR: cli: dequeue from the proxy when changing a maxconn The "set maxconn frontend" statement on the CLI tries to dequeue possibly pending requests, but due to a copy-paste error, they're dequeued on the CLI's frontend instead of the one being changed. The impact is very minor as it only means that possibly pending connections will still have to wait for a previous one to complete before being accepted when a limit is raised. This fix has to be backported to 1.6 and 1.5. --- src/dumpstats.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/dumpstats.c b/src/dumpstats.c index e22d0744c..fe1ad48dc 100644 --- a/src/dumpstats.c +++ b/src/dumpstats.c @@ -1890,8 +1890,8 @@ static int stats_sock_parse_request(struct stream_interface *si, char *line) resume_listener(l); } - if (px->maxconn > px->feconn && !LIST_ISEMPTY(&strm_fe(s)->listener_queue)) - dequeue_all_listeners(&strm_fe(s)->listener_queue); + if (px->maxconn > px->feconn && !LIST_ISEMPTY(&px->listener_queue)) + dequeue_all_listeners(&px->listener_queue); return 1; }