mirrors/haproxy
1
0
Fork 0
mirror of https://git.haproxy.org/git/haproxy.git/ synced 2025-08-09 16:47:18 +02:00
Code Issues Projects Releases Wiki Activity

BUG/MEDIUM: servers: Close the connection if we failed to install the mux.

Browse Source 
If we failed to install the mux, just close the connection, or
conn_fd_handler() will be called for the FD, and crash as soon as it attempts
to access the mux' wake method.

This should be backported to 1.9.
This commit is contained in:
Olivier Houchard 2019-01-29 19:11:16 +01:00 committed by Willy Tarreau
parent ef60ff38fb
commit 7493114729
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/backend.c
View File

@ -1465,8 +1465,10 @@ int connect_server(struct stream *s)
* fail, and flag the connection as CO_FL_ERROR. * fail, and flag the connection as CO_FL_ERROR.
*/ */
if (init_mux) { if (init_mux) {
if (conn_install_mux_be(srv_conn, srv_cs, s->sess) < 0) if (conn_install_mux_be(srv_conn, srv_cs, s->sess) < 0) {
conn_full_close(srv_conn);
return SF_ERR_INTERNAL; return SF_ERR_INTERNAL;
}
/* If we're doing http-reuse always, and the connection /* If we're doing http-reuse always, and the connection
* is an http2 connection, add it to the available list, * is an http2 connection, add it to the available list,
* so that others can use it right away. * so that others can use it right away.